Create a resolver API for picking a checkout flow #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures are phpcs related |
mglaman
requested changes
Jan 11, 2017
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function addResolver(CheckoutFlowResolverInterface $resolver, $priority) { |
There was a problem hiding this comment.
Remove $priority parameter, we removed this in HEAD
| * {@inheritdoc} | ||
| */ | ||
| public function addResolver(CheckoutFlowResolverInterface $resolver, $priority) { | ||
| $this->resolvers[$priority] = $resolver; |
| } | ||
|
|
||
| return $order->checkout_flow->entity; | ||
| return $this->chainCheckoutFlowResolver->resolve($order); |
There was a problem hiding this comment.
This needs if ($order->checkout_flow->isEmpty()) {
| * {@inheritdoc} | ||
| */ | ||
| public function resolve(OrderInterface $order) { | ||
| if ($order->checkout_flow->isEmpty()) { |
There was a problem hiding this comment.
Move check to heckoutOrderManager
mglaman
approved these changes
Jan 11, 2017
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
68e6e5f to
ac287b7
Compare
mglaman
reviewed
Jan 17, 2017
| } | ||
|
|
||
| public function __sleep() { | ||
| return parent::__sleep(); // TODO: Change the autogenerated stub |
There was a problem hiding this comment.
This is going to be removed. But in debugging the __sleep method of the parent is invoking \Drupal::service which says that $container is empty.
bojanz
changed the title
bradjones1
pushed a commit
to bradjones1/commerce
that referenced
this pull request
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://www.drupal.org/node/2710989