2757283 template admin order view #565
Conversation
| 'commerce_order_edit_form' => [ | ||
| 'render element' => 'form', | ||
| ], | ||
| 'commerce_order__default' => [ |
There was a problem hiding this comment.
Discussed w/ @cornifex we'd make an admin view mode and use that instead
There was a problem hiding this comment.
Looks like we'd have to alter the default canonical route, Core provides
'_entity_view' => "{$entity_type_id}.full",
There was a problem hiding this comment.
Discussed w/ Bojan. Doesn't really give us a gain. And tests showed all kinds of madness by doing this.
mglaman
force-pushed
the
2757283-template-admin-order-view
branch
from
ce6e9f5 to
5ba9504
Compare
| {% endfor %} | ||
| </div> | ||
| </details> | ||
| {% for key,value in {'billing_information': 'Billing information'|t, 'shipping_information': 'Shipping information'|t} %} |
There was a problem hiding this comment.
@bojanz I followed the same concepts from the email, since this is pretty hardcoded-ish.
|
@bojanz this is ready to take a peak at. |
| </div> | ||
| <details open> | ||
| <summary role="button"> | ||
| Customer Information |
There was a problem hiding this comment.
Missing |t for Customer information.
| #} | ||
|
|
||
| {{ attach_library('commerce_order/form') }} | ||
| {% set order_state = order_entity.getState.value|capitalize %} |
There was a problem hiding this comment.
You're capitalizing the machine name of the state, instead of taking the label. That's not right.
There was a problem hiding this comment.
Ah so we need getState.getLabel?
modules/order/commerce_order.module
Outdated
| } | ||
|
|
||
| if ($order->getBillingProfile()) { | ||
| $variables['order']['billing_information'] = $order->getBillingProfile()->get('address')->view([ |
There was a problem hiding this comment.
Why would we not render the entire billing profile? Doing it this way means no phone field / VAT number is shown even if the fields are attached.
There was a problem hiding this comment.
That works, get can just render it full
| {% endfor %} | ||
| </div> | ||
| </details> | ||
| {% for key,value in {'billing_information': 'Billing information'|t, 'shipping_information': 'Shipping information'|t} %} |
There was a problem hiding this comment.
It feels like it would be better for TX (themer experience) if these for loops were unrolled.
We have two elements here, repeating their HTML twice is probably no big deal?
| {# | ||
| /** | ||
| * @file | ||
| * Default order template. |
There was a problem hiding this comment.
Let's add something like "Used on the admin order page." so that the themers know which template they need.
mglaman
force-pushed
the
2757283-template-admin-order-view
branch
2 times, most recently
from
b08663c to
656d4eb
Compare
mglaman
force-pushed
the
2757283-template-admin-order-view
branch
from
656d4eb to
8397f4f
Compare
|
Captain @bojanz, your needs have been addressed |
|
Continued in #574. |
3 participants
This is just a rough template using all twig with no preprocessing. Definitely needs more work but I've been given other priorities for the time being.