Issue #2860840 : Product variantion add to cart not translated. #682
Conversation
…roduct variantion add to cart not translated.
| */ | ||
| public function getTranslatedReferencedEntities($field_name) { | ||
| $refereced_entities = $this->get($field_name)->referencedEntities(); | ||
| return $this->ensureTranslations($refereced_entities); |
There was a problem hiding this comment.
typo error on $refereced_entities. I guess you miss a 'n' in $referenced_entities
| /** | ||
| * Provides the base class for Commerce content entities. | ||
| */ | ||
| class CommerceContentEntityBase extends ContentEntityBase implements CommerceContentEntityInterface { |
There was a problem hiding this comment.
If this is a base class, it must be abstract
There was a problem hiding this comment.
Also, this only provides a public method for trnslated references. So really only relates to Product.
There was a problem hiding this comment.
i think the usage could be extented on other place - for example any getStore(s) needs
and thanks
There was a problem hiding this comment.
How would stores need this? It doesn't have an architecture which has a concept of "child references"
| $attributes[$field_name] = [ | ||
| 'field_name' => $field_name, | ||
| 'title' => $field->getLabel(), | ||
| 'title' => $this->t($field->getLabel()), |
There was a problem hiding this comment.
There's no need to wrap this in translatable markup, as the field is config and config is already translatable
There was a problem hiding this comment.
i know, but there the field label won't get translated
i will update with some getTranslationFromContext somehow
…o 2860840-add-to-cart-multilingual
…o 2860840-add-to-cart-multilingual
…o 2860840-add-to-cart-multilingual
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
77bfcc5 to
c15564f
Compare
bojanz
force-pushed
the
8.x-2.x
branch
3 times, most recently
from
1028fc1 to
005e904
Compare
…o 2860840-add-to-cart-multilingual
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
6be1d5c to
b8a7444
Compare
…o 2860840-add-to-cart-multilingual
…ing after order add/edit
…ormalized and serialized
# Conflicts: # modules/product/tests/src/Kernel/ProductVariationGeneratedTitleTest.php # modules/product/tests/src/Kernel/ProductVariationStorageTest.php
# Conflicts: # modules/product/src/Entity/ProductVariation.php # src/Entity/CommerceContentEntityBase.php
# Conflicts: # modules/product/tests/src/Kernel/ProductVariationGeneratedTitleTest.php
mglaman
force-pushed
the
2860840-add-to-cart-multilingual
branch
from
db26e27 to
7df708f
Compare
|
Committed in 7af1dd8 |
3 participants
No description provided.