WIP -- Fixing CI. #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade netpick version in poetry - change setup.cfg
Member
|
Yes, please. The CI is the boss here. You can do whatever it says. |
added 2 commits
May 28, 2020 10:51
- upgrade netpick version in poetry - change setup.cfg
- upgrade netpick, urllib3, pyyaml versions in poetry - change setup.cfg
sobolevn
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing CI i found the last issue with [isort] in setup.cfg.
flake8 told me to set line_length = 80 , but now it's 79 and have the comment about the reason ('# Should be: 80 - 1'). Why it's 80-1? Should i change it to 80?