WIP: fixing dependencies #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade netpick version in poetry - change setup.cfg
- upgrade netpick version in poetry - change setup.cfg
- upgrade netpick, urllib3, pyyaml versions in poetry - change setup.cfg
- conf.py fixed (flake8 violation) - poetry.lock updated. flake8-pytest-style still not updated.
- conf.py fixed (flake8 violation) - poetry.lock updated. - sphinx updated to 3.0.4 cuz of safety. flake8-pytest-style still not updated.
…sue--fix_dependencies
1. After updating flake8-rst-docstrings to 0.0.12 i have the violation RST214 about docstring in ./classes/typeclass.py . I cant imagine how i can fix this docstring :( It seems to me that replacing the first letter with a capital letter is not quite the right solution? 2. I still have pip check error of importlib-metadata like python-poetry/poetry#2042 , but i can`t find any dependencies of it in poetry.toml or poetry.lock.
Contributor
Author
|
Oh, the second trouble (with poetry dependency of importlib-metadata) is my local. Great! Then only docstring violation left. |
Member
|
👍 Waiting for the CI to get green and merging! Thanks a lot! |
Contributor
Author
|
Help me please with flake8 violation. Reformulating dockstrings is not easy for me. How I can fix it? |
Member
|
This happens due to improperly formatted Fix: |
Contributor
Author
|
Sorry, it was that. |
Contributor
Author
|
Wait, please. I forgot about flake8-pytest-style. Major update :( |
sobolevn
approved these changes
Jun 3, 2020
Member
|
Let's make a separate PR for it. It will requires some test refactoring. |
Member
|
Thanks a lot, @mikhail-akimov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brunch with my previous changes (am i right with that?).