Skip to content

Conversation

teppeis
Copy link
Contributor

@teppeis teppeis commented Feb 5, 2019

npm install and creating a patch, then npm ci fails:

patch-package 6.0.2
Applying patches...

Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    google-closure-library@20190121.0.0

  applied to

    google-closure-library@v20190121.0.0
  
  At path
  
    node_modules/google-closure-library

The original version of the package.json is v20190121.0.0.

This issue is caused by difference between behavior of npm install and npm ci.
npm install normalizes version in package.json of deps (v20190121.0.0 is changed to 20190121.0.0) but npm ci doesn't (just v20190121.0.0).

This PR normalizes the version with semver.

repro: https://github.com/teppeis/closure-library.d.ts

@teppeis teppeis changed the title Fix for npm ci Fix: normalize version for npm ci Feb 5, 2019
@ds300
Copy link
Owner

ds300 commented Feb 7, 2019

thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants