Skip to content

Conversation

@rdiaztushman
Copy link

No description provided.

@rdiaztushman
Copy link
Author

Here's a PR with the current version of the plugin that we're using

@coveralls
Copy link

Coverage Status

Coverage decreased (-64.2%) to 35.849% when pulling 66fe339 on dioscouri:master into 676c4ab on dsanel:master.

@rdiaztushman
Copy link
Author

Weird. Why did coverage decrease like that, @dsanel ?

@dsanel
Copy link
Owner

dsanel commented Jun 20, 2016

I will check it! ;)

I will merge PR #11 but for this PR we need to create additional option. We can use option indexDeleteFields or similar so a user can decide to index or not those fields.

I will work on this later today ;)

@dsanel dsanel closed this Jun 20, 2016
@rdiaztushman
Copy link
Author

Ok. Sounds good for "deletedBy" and "deletedAt", so I would make those optional, but I can't imagine a scenario where a user would NOT want to index the "deleted" field (since this plugin forces every query to filter against it) so I wouldn't bother creating an option for that field.

@dsanel
Copy link
Owner

dsanel commented Jun 20, 2016

I understand you point, but this plugin is used by big number or users and it will be very irresponsible to force all users to reindex any field. Mongoose automatically calls ensureIndex for each defined index in your schema and if a user does not disable this option it can make unwanted changes...

I will create options for all three fields and it will be best for everyone. I believe that you will like the solution. ;)

@dsanel
Copy link
Owner

dsanel commented Jun 20, 2016

We have new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants