Replace OrbiterSound with XRSound#512
Closed
ethhics wants to merge 8 commits into
Closed
Conversation
Contributor
|
Thanks for working on this. Looks like a big project. I can't contribute much at the moment, I'm too deep into working on some RTCC MFD stuff. How about you continue on the path you are right now with this PR and try to get some things working, I think it definitely is on the way to be able to be merged at some point. If you want to talk about some of the details or have any questions concerning the NASSP code, feel free to stop by in our IRC channel (#nassp on freenode), that's where we usually hang out. |
Member
|
This is still on the roadmap and it would be nice to have for NASSP 8, this does however need rework to be compatible with the current state of NASSP and it's probably easier to redo these changes from the latest state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is NOT complete! Don't merge yet.
Closes #474 .
I want to provide a starting point for y'all before this just sits on my hard drive. Feel free to commit to this branch as needed to finish the implementation.
What is implemented
src_sys/soundlibhas a complete implementation of XRSound in a way that should require minimal modification of any other code.Still to be done
XRSound.dllbeforeXRSound.dllis loaded. This results in nothing being configured from a sound perspective. It appears that the vessels'soundlibcode will need to be shifted around so that nothing happens beforeclbkPostCreation.soundliband everything related to sounds playing and rewrite it in the object-oriented style of XRSound and take advantage of features like >60 samples. I'm unfamiliar with this project's code philosophy, so if that's more of the approach y'all'd like, just close this PR and I'll devise a strategy for a more thorough codebase surgery.