Refactor PR #30 and add tests #36
Merged
+82
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Owner
Author
|
Cc @thomwiggers |
thomwiggers
approved these changes
Sep 17, 2021
Contributor
thomwiggers
left a comment
thomwiggers
left a comment
There was a problem hiding this comment.
I don't really know how any of this wrapping works, but seems legit.
Owner
Author
|
@thomwiggers That's fine :) I was mostly aiming for a couple of extra eyes on the I'll get you a beer next time we see each other :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request for review
This PR refactors the code from #30 and adds tests. I would appreciate a pair of extra eyes on this if somebody is willing to sacrifice some time. <3