fix: update tests to match lenient behavior

Author: haydnli-shopify

src/tests/_internal/server/routers/test_projects.py

@@ -628,22 +628,28 @@ async def test_global_admin_manager_can_set_project_admins(
 
     @pytest.mark.asyncio
     @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)
-    async def test_add_member_returns_404_for_nonexistent_user(self, test_db, session: AsyncSession, client: AsyncClient):
+    async def test_add_member_skips_nonexistent_user(self, test_db, session: AsyncSession, client: AsyncClient):
         # Setup project and admin
         project = await create_project(session=session, created_at=datetime(2023, 1, 2, 3, 4, tzinfo=timezone.utc))
         admin = await create_user(session=session, created_at=datetime(2023, 1, 2, 3, 4, tzinfo=timezone.utc))
         await add_project_member(session=session, project=project, user=admin, project_role=ProjectRole.ADMIN)
 
-        # Try to add non-existent user
+        # Try to add non-existent user - should succeed but skip the non-existent user
         body = {"members": {"username": "nonexistent", "project_role": "user"}}
         response = await client.post(
             f"/api/projects/{project.name}/add_member",
             headers=get_auth_headers(admin.token),
             json=body,
         )
 
-        # The service layer returns 400 for non-existent users, not 404
-        assert response.status_code == 400
+        # Operation succeeds but non-existent user is silently skipped
+        assert response.status_code == 200
+        response_data = response.json()
+        
+        # Only the admin should be present (non-existent user was skipped)
+        member_usernames = [member["user"]["username"] for member in response_data["members"]]
+        assert "nonexistent" not in member_usernames
+        assert admin.name in member_usernames
 
     @pytest.mark.asyncio
     @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)
@@ -782,22 +788,28 @@ async def test_add_member_updates_existing_role(self, test_db, session: AsyncSes
 
     @pytest.mark.asyncio
     @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)
-    async def test_add_member_returns_404_for_nonexistent_user(self, test_db, session: AsyncSession, client: AsyncClient):
+    async def test_add_member_skips_nonexistent_user(self, test_db, session: AsyncSession, client: AsyncClient):
         # Setup project and admin
         project = await create_project(session=session, created_at=datetime(2023, 1, 2, 3, 4, tzinfo=timezone.utc))
         admin = await create_user(session=session, created_at=datetime(2023, 1, 2, 3, 4, tzinfo=timezone.utc))
         await add_project_member(session=session, project=project, user=admin, project_role=ProjectRole.ADMIN)
 
-        # Try to add non-existent user
+        # Try to add non-existent user - should succeed but skip the non-existent user
         body = {"members": {"username": "nonexistent", "project_role": "user"}}
         response = await client.post(
             f"/api/projects/{project.name}/add_member",
             headers=get_auth_headers(admin.token),
             json=body,
         )
 
-        # The service layer returns 400 for non-existent users, not 404
-        assert response.status_code == 400
+        # Operation succeeds but non-existent user is silently skipped
+        assert response.status_code == 200
+        response_data = response.json()
+        
+        # Only the admin should be present (non-existent user was skipped)
+        member_usernames = [member["user"]["username"] for member in response_data["members"]]
+        assert "nonexistent" not in member_usernames
+        assert admin.name in member_usernames
 
     @pytest.mark.asyncio
     @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)
@@ -882,26 +894,26 @@ async def test_remove_member_by_email(self, test_db, session: AsyncSession, clie
 
     @pytest.mark.asyncio
     @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)
-    async def test_remove_member_returns_404_for_nonexistent_user(self, test_db, session: AsyncSession, client: AsyncClient):
+    async def test_remove_member_skips_nonexistent_user(self, test_db, session: AsyncSession, client: AsyncClient):
         # Setup project and admin
         project = await create_project(session=session, created_at=datetime(2023, 1, 2, 3, 4, tzinfo=timezone.utc))
         admin = await create_user(session=session, created_at=datetime(2023, 1, 2, 3, 4, tzinfo=timezone.utc))
         await add_project_member(session=session, project=project, user=admin, project_role=ProjectRole.ADMIN)
 
-        # Try to remove non-existent user
+        # Try to remove non-existent user - should succeed but skip the non-existent user
         body = {"usernames": "nonexistent"}
         response = await client.post(
             f"/api/projects/{project.name}/remove_member",
             headers=get_auth_headers(admin.token),
             json=body,
         )
 
-        # The service layer returns 400 for non-existent users, not 404
-        assert response.status_code == 400
+        # Operation succeeds but non-existent user is silently skipped
+        assert response.status_code == 200
 
     @pytest.mark.asyncio
     @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)
-    async def test_remove_member_returns_400_for_non_members(self, test_db, session: AsyncSession, client: AsyncClient):
+    async def test_remove_member_skips_non_members(self, test_db, session: AsyncSession, client: AsyncClient):
         # Setup project and admin
         project = await create_project(session=session, created_at=datetime(2023, 1, 2, 3, 4, tzinfo=timezone.utc))
         admin = await create_user(session=session, created_at=datetime(2023, 1, 2, 3, 4, tzinfo=timezone.utc))
@@ -910,15 +922,16 @@ async def test_remove_member_returns_400_for_non_members(self, test_db, session:
         # Create user who is NOT a member
         non_member = await create_user(session=session, name="nonmember", created_at=datetime(2023, 1, 2, 3, 4, tzinfo=timezone.utc))
 
-        # Try to remove non-member
+        # Try to remove non-member - should succeed but skip the non-member
         body = {"usernames": "nonmember"}
         response = await client.post(
             f"/api/projects/{project.name}/remove_member",
             headers=get_auth_headers(admin.token),
             json=body,
         )
 
-        assert response.status_code == 400
+        # Operation succeeds but non-member is silently skipped
+        assert response.status_code == 200
 
     @pytest.mark.asyncio
     @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)
@@ -938,8 +951,8 @@ async def test_remove_member_prevents_removing_last_admin(self, test_db, session
 
         assert response.status_code == 400
         response_json = response.json()
-        # The actual error message format includes details in an array
-        assert "Cannot remove the last project admin" in str(response_json)
+        # Check for the actual error message we use
+        assert "Cannot remove all project admins" in str(response_json)
 
     @pytest.mark.asyncio
     @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)