-
Notifications
You must be signed in to change notification settings - Fork 205
Add missing project SSH key to on-prem instances #1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing project SSH key to on-prem instances #1716
Conversation
|
It'd be nice to refactor the code to use project.ssh_private_key when connecting to remote instances such as here: dstack/src/dstack/_internal/server/background/tasks/process_running_jobs.py Lines 136 to 146 in 1ce1243
It may not be ideal doing in this release since it may break connecting to old instances. @un-def, maybe leave TODOs for that? |
@un-def, if this is still the case, please also add a new issue to fix it later by using the project key for remote instance connections from server and CLI. |
|
@jvstme, it is not and was not the case, when a run is submitted to the shim, the user's public key (either provided by the user or generated by The project key, as far as I understand, it's not even available to the user. |
* Add `proxy_jump` property * Store configuration as part of `RemoteConnectionInfo` * Always use a project key to connect to SSH instances, drop backward compatibility code (previously, the user-provided key was used, as the project key was not added to the SSH instance, this was fixed in #1716) NOTE: services are not currently supported, proxy support will be added in a separate PR. Part-of: #2010
* Add `proxy_jump` property * Store configuration as part of `RemoteConnectionInfo` * Always use a project key to connect to SSH instances, drop backward compatibility code (previously, the user-provided key was used, as the project key was not added to the SSH instance, this was fixed in #1716) NOTE: services are not currently supported, proxy support will be added in a separate PR. Part-of: #2010
* Add `proxy_jump` property * Store configuration as part of `RemoteConnectionInfo` * Always use a project key to connect to SSH instances, drop backward compatibility code (previously, the user-provided key was used, as the project key was not added to the SSH instance, this was fixed in #1716) Part-of: #2010 Co-authored-by: Victor Skvortsov <vds003@gmail.com>
* Add `proxy_jump` property * Store configuration as part of `RemoteConnectionInfo` * Always use a project key to connect to SSH instances, drop backward compatibility code (previously, the user-provided key was used, as the project key was not added to the SSH instance, this was fixed in dstackai#1716) Part-of: dstackai#2010 Co-authored-by: Victor Skvortsov <vds003@gmail.com>
* Add `proxy_jump` property * Store configuration as part of `RemoteConnectionInfo` * Always use a project key to connect to SSH instances, drop backward compatibility code (previously, the user-provided key was used, as the project key was not added to the SSH instance, this was fixed in dstackai#1716) Part-of: dstackai#2010 Co-authored-by: Victor Skvortsov <vds003@gmail.com>
Fixes: #1640