[chore]: Refactor gateway modules #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Feb 9, 2025
* Split `core.models.gateways` in two * Split `server.services.gateways` in two
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 4, 2025
* Split `core.models.gateways` in two * Split `server.services.gateways` in two
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 5, 2025
* Split `core.models.gateways` in two * Split `server.services.gateways` in two
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move service-specific logic out of gateway-specific modules, since gateways are no longer the only way to run services.
The naming of modules may be a bit confusing because the word "service" can refer to both
type: serviceruns and theservicesarchitectural layer. This leads to module names such asdstack._internal.server.services.services. The PR attempts to avoid confusion by adding module docstrings.Part of #1595