Full EFA attachment for non-public IPs #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4victor
reviewed
Feb 7, 2025
Comment on lines
208
to
239
| if instance_type == "p5.48xlarge": | ||
| # EFA configuration for P5 instances: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/efa-acc-inst-types.html#efa-for-p5 | ||
| p5d_interfaces = [ | ||
| { | ||
| "NetworkCardIndex": i, | ||
| "DeviceIndex": 1, | ||
| "InterfaceType": "efa" if i % 4 == 0 else "efa-only", | ||
| } | ||
| for i in range(1, 32) | ||
| ] | ||
| for interface in p5d_interfaces: | ||
| struct["NetworkInterfaces"].append( | ||
| { | ||
| "AssociatePublicIpAddress": allocate_public_ip, | ||
| "NetworkCardIndex": interface["NetworkCardIndex"], | ||
| "DeviceIndex": interface["DeviceIndex"], | ||
| "SubnetId": subnet_id, | ||
| "Groups": [security_group_id], | ||
| "InterfaceType": interface["InterfaceType"], | ||
| } | ||
| ) | ||
| else: | ||
| for i in range(1, max_efa_interfaces): | ||
| struct["NetworkInterfaces"].append( | ||
| { | ||
| "AssociatePublicIpAddress": allocate_public_ip, | ||
| "NetworkCardIndex": i, | ||
| "DeviceIndex": 1, | ||
| "SubnetId": subnet_id, | ||
| "Groups": [security_group_id], | ||
| "InterfaceType": "efa-only", # Set specifically to efa-only to keep the interfaces exclusively for GPU-to-GPU communications and not mix with IP traffic | ||
| } |
Collaborator
There was a problem hiding this comment.
It seems "InterfaceType" is the only difference between "p5.48xlarge" and other instance types? Then the code can be simplified significantly:
for i in range(1, max_efa_interfaces):
# Set efa-only to keep the interfaces exclusively for GPU-to-GPU communications and not mix with IP traffic
interface_type = "efa-only"
if instance_type == "p5.48xlarge":
# EFA configuration for P5 instances:
# https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/efa-acc-inst-types.html#efa-for-p5
interface_type = "efa" if i % 4 == 0 else "efa-only"
struct["NetworkInterfaces"].append(
{
"AssociatePublicIpAddress": allocate_public_ip,
"NetworkCardIndex": i,
"DeviceIndex": 1,
"SubnetId": subnet_id,
"Groups": [security_group_id],
"InterfaceType": interface_type,
}
)
Contributor
Author
There was a problem hiding this comment.
Sorry, pushed the choppy version without refactoring. Fixed.
Collaborator
|
@solovyevt, thanks for the PR, looks good. I'm merging it. I also pushed a commit to update the docs. |
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 4, 2025
* feature(aws): Extend EFA attachment * refactor(aws): Simplify NetworkInterfaces logic * Update docs on EFA --------- Co-authored-by: Solovev, Timur <tsolovev@ea.com> Co-authored-by: Victor Skvortsov <vds003@gmail.com>
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 5, 2025
* feature(aws): Extend EFA attachment * refactor(aws): Simplify NetworkInterfaces logic * Update docs on EFA --------- Co-authored-by: Solovev, Timur <tsolovev@ea.com> Co-authored-by: Victor Skvortsov <vds003@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2270