Introduce ComputeWith classes to detect compute features #2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvstme
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2372
This PR moves optional
Computemethods toComputeWith*feature classes. This makes it explicit which methods are required for different features and also allows buildingBACKENDS_WITH_*lists dynamically instead of hardcoding them.Notes:
assert isinstance(compute, ComputeWithPlacementGroupSupport). This is still better than previous implicit assumption about method being implemented.BACKENDS_WITH_*lists now contain only available backend types. This does not affect any behavior except for error messages that return supported backend types. Errors are clarified to return available backend types.