Restore removed models fields for compatibility with 0.18 clients #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4victor
commented
Mar 17, 2025
| if not kwargs.get("deep", False): | ||
| raise TypeError(f"shallow copying of {self.__class__.__name__} is prohibited") | ||
| return super().copy(**kwargs) | ||
| new_copy.__root__ = new_copy.__root__.copy() |
Collaborator
Author
There was a problem hiding this comment.
@un-def, I had to implement shallow copy for Env somehow because if a model defines excludes/includes, pydantic performs shallow copy for fields internally when calling copy(deep=True). Yes, copy(deep=True) may call copy(deep=False).
un-def
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR restores recently removed models fields to keep the server compatible with 0.18 clients that continue to send those fields as
null. It also excludes the fields so that the new clients do not send them and the fields can be removed in the future.