Add new metrics #2434
Merged
Add new metrics #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `memory_total_bytes` * `gpu_memory_total_bytes` * `cpus_detected_num`
r4victor
reviewed
Mar 19, 2025
| def _make_constant_metric(name: str, timestamps: list[datetime], value: float) -> Metric: | ||
| return Metric( | ||
| name=name, | ||
| timestamps=[timestamps[0], timestamps[-1]] if len(timestamps) > 1 else [timestamps[0]], |
Collaborator
There was a problem hiding this comment.
I think we need to document the format for constant metrics. Also unsure if it's worth having a special case for constant metrics at all to save some bytes. I'd return all the timestamps.
Collaborator
Author
There was a problem hiding this comment.
Removed the special case, constant metrics now use the same timestamps as regular metrics.
r4victor
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory_total_bytesgpu_memory_total_bytescpus_detected_num