-
Notifications
You must be signed in to change notification settings - Fork 198
[Feature]: Store user SSH key on the server #3176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| warn( | ||
| f"Using legacy [code]{config_manager.dstack_key_path}[/code]." | ||
| " Future versions will use the user SSH key from the server.", | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the user supposed to do anything when they see this warning? If not, the warning is unnecessary and will probably only confuse the user, since they typically don't think about what keys dstack uses internally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to keep the warning for now, but we can remove it in a separate PR once we’ve dogfooded it more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think seeing it on every apply and attach and not being able to do anything about it will be a bit annoying. Anyways, it's up to you
Co-authored-by: jvstme <36324149+jvstme@users.noreply.github.com>
Review: move `ssh_public_key` to `User` model (from `UserWithCreds`)
Fixes #2053
ssh_private_keyandssh_public_key. These properties are automatically assigned when users are created or when a user submits a run without specifying a public key.Warning
The CLI still assigns the public key from the legacy local SSH key. However, if a run was submitted without an SSH key (for example, via the API and automatically assigned the user’s public key), the new CLI will be able to attach to it using the user’s key.
Backward compatibility:
Warning
Since 0.19.40, the client will stop using the legacy local SSH key and will require that all users have updated their servers to at least 0.19.33.