Restructure of 'How-to-add-a backend' contribution guide #917
Conversation
|
@Egor-S Requested changes made. |
contributing/BACKENDS.md
Outdated
| - API for creating and terminating containers | ||
| - Safe imports | ||
|
|
||
| Examples: Amazon Elastic Container Service(ECS), Google Cloud Run |
There was a problem hiding this comment.
We don't support these. There should be kubernetes and vastai
contributing/BACKENDS.md
Outdated
| To speed up provisioning, we prebuild VM images with necessary dependencies, available in `packer/`. | ||
|
|
||
| ### Adding Docker-only compute backend | ||
| Examples: Microsoft Azure, AWS, Google Cloud Platform |
There was a problem hiding this comment.
Please, use dstack internal names. azure, gcp, etc.
contributing/BACKENDS.md
Outdated
| - cloud-init script (preferable) | ||
| - cloud-init script (preferred) | ||
| - API for creating and terminating instances | ||
| - Safe imports |
There was a problem hiding this comment.
I guess my previous comment was not clear, my bad. It should not be there, because it has nothing to do with backends, only Python code in dstack itself.
There was a problem hiding this comment.
Still unclear, I had safe imports originally under finalising integration this way:
Add a safe import for your backend in src/dstack/_internal/server/services/backends/__init__.py
Should this change?
There was a problem hiding this comment.
This quote is correct, it should stay. Safe imports are related to this exact file (src/dstack/_internal/server/services/backends/__init__.py).
|
@Egor-S Changes made |
3 participants
Fixes #915
Restructured into sections:
gpuhuntdstacksetup.py