mongodb busiCall 中允许添加返回是否自动提交事务 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catcherwong
reviewed
Jan 23, 2024
catcherwong
reviewed
Jan 24, 2024
| } | ||
| } | ||
|
|
||
| public static async Task MongoCall(this BranchBarrier bb, IMongoClient mc, Func<IClientSessionHandle, Task<bool>> busiCall) |
Contributor
Author
There was a problem hiding this comment.
两个方法代码重合度很高，最好做一个抽取
好的，我重新提交了
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 70.99% 69.10% -1.90%
==========================================
Files 44 44
Lines 1903 1903
Branches 0 180 +180
==========================================
- Hits 1351 1315 -36
Misses 552 552
- Partials 0 36 +36 ☔ View full report in Codecov by Sentry. |
catcherwong
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mongodb busiCall 中有些场景需要直接在内部终止事务，目前只能通过抛出异常，被MongoCall中的catch捕获后，终止。我添加了一个新的MongoCall方法，并且在
busiCallFunction中 添加了Task<bool>返回值