Feature: DtmClient add query single trans global status/detail #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Query method in DtmClient and IDtmClient to retrieve global transaction details - Define TransGlobal class to represent the structure of a global transaction - Update Constant to include new URL for query endpoint
Implement a new HTTP GET endpoint for querying transaction status
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 68.82% 69.61% +0.79%
==========================================
Files 44 45 +1
Lines 1915 1965 +50
Branches 182 185 +3
==========================================
+ Hits 1318 1368 +50
Misses 560 560
Partials 37 37 ☔ View full report in Codecov by Sentry. |
wooln
force-pushed
the
feature/query-TransGlobal
branch
from
89c39d1 to
6ca3b79
Compare
Member
|
LGTM, but could we improve the coverage? |
wooln
force-pushed
the
feature/query-TransGlobal
branch
from
4d4dd50 to
1089b34
Compare
Contributor
Author
Done. |
catcherwong
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDtmClient.cs/DtmClient.cs