build: add new strong-named assemblies for dtm client DtmCommon, Dtmcli, Dtmgrpc, Dtmworkflow #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 68.82% 68.82%
=======================================
Files 44 44
Lines 1915 1915
Branches 182 182
=======================================
Hits 1318 1318
Misses 560 560
Partials 37 37 ☔ View full report in Codecov by Sentry. |
- Add StringNameKey file and StringNamePublicKey properties for assembly signing
- Add new projects for creating strong-named assemblies
- Dtmcli.StrongName
- DtmCommon.StrongName, replace Dapper package with Dapper.StrongName
- Dtmgrpc.StrongName
- Dtmworkflow.StrongName
- New assembly is copied from .csproj file, and links .cs and .proto file to compile
- Update solution file to include new projects
wooln
force-pushed
the
feature/sign-assembly
branch
from
5d556fe to
de9f6ad
Compare
wooln
changed the title
wooln
force-pushed
the
feature/sign-assembly
branch
from
e6570d9 to
7064311
Compare
wooln
force-pushed
the
feature/sign-assembly
branch
from
7064311 to
ecfe2bd
Compare
catcherwong
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: add new strong-named assemblies for dtm client
- DtmCommon.StrongName, replace Dapper package with Dapper.StrongName
- Dtmcli.StrongName
- Dtmgrpc.StrongName
- Dtmworkflow.StrongName
Tips: the following dependents do NOT have strong name
solution like this
