Skip to content

Fix exported symbols on Mac #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
+27 −2
Merged

Fix exported symbols on Mac #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/Java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ jobs:
make -C /duckdb release
"

- name: List Symbols
run: |
nm -gU ./build/release/libduckdb_java.so_linux_amd64

- name: JDBC Tests EL8
if: ${{ inputs.skip_tests != 'true' }}
run: |
Expand Down Expand Up @@ -218,6 +222,9 @@ jobs:
source /opt/rh/gcc-toolset-12/enable
make -C /duckdb release
"
- name: List Symbols
run: |
nm -gU ./build/release/libduckdb_java.so_linux_arm64

- name: JDBC Tests EL8
shell: bash
Expand Down Expand Up @@ -283,6 +290,10 @@ jobs:
${{ env.ALPINE_IMAGE }} \
sh -c 'apk add ${{ env.ALPINE_PACKAGES }} && make -C /duckdb release'

- name: List Symbols
run: |
nm -gU ./build/release/libduckdb_java.so_linux_amd64

- name: JDBC Tests
shell: bash
if: ${{ inputs.skip_tests != 'true' }}
Expand Down Expand Up @@ -328,6 +339,10 @@ jobs:
${{ env.ALPINE_IMAGE }} \
sh -c 'apk add ${{ env.ALPINE_PACKAGES }} && make -C /duckdb release'

- name: List Symbols
run: |
nm -gU ./build/release/libduckdb_java.so_linux_arm64

# Test runs are failing because of linux_arm64_musl extensions missing
- name: JDBC Tests
shell: bash
Expand Down Expand Up @@ -370,6 +385,12 @@ jobs:
shell: bash
run: make release

- name: List Symbols
shell: cmd
run: |
call "c:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
dumpbin.exe /exports build\release\Release\libduckdb_java.so_windows_amd64

- name: Java Tests
if: ${{ inputs.skip_tests != 'true' }}
shell: bash
Expand Down Expand Up @@ -404,6 +425,10 @@ jobs:
shell: bash
run: make release

- name: List Symbols
run: |
nm -gU ./build/release/libduckdb_java.so_osx_universal

- name: Java Tests
if: ${{ inputs.skip_tests != 'true' }}
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-Bsymbolic-functions
-fvisibility=hidden
-Wl,--version-script=${CMAKE_CURRENT_LIST_DIR}/duckdb_java.map)
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
target_link_options(duckdb_java PRIVATE
-fvisibility=hidden
-Wl,-exported_symbols_list,${CMAKE_CURRENT_LIST_DIR}/duckdb_java.exp)
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-Bsymbolic-functions
-fvisibility=hidden
-Wl,--version-script=${CMAKE_CURRENT_LIST_DIR}/duckdb_java.map)
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
target_link_options(duckdb_java PRIVATE
-fvisibility=hidden
-Wl,-exported_symbols_list,${CMAKE_CURRENT_LIST_DIR}/duckdb_java.exp)
Expand Down