Parameters in mysql_query and mysql_execute #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new optional
params
argument tomysql_query
andmysql_execute
functions that allows to pass query parameters to an underlying MySQL prepared statement (that was added in #156).Parameters are specified as a
STRUCT
, that can be created inline usingrow()
function:When the whole DuckDB SQL statement, that contains
mysql_query()
function, is used withPREPARE
+EXECUTE
(for example, from Python or Java client), then the external client-provided parameters will be forwarded to MySQL:In current implementation the statement is re-prepared (re-sent to MySQL server) every time when
EXECUTE
is called.The following parameter types are supported: integers,
FLOAT
,DOUBLE
,DATE
,TIME
,TIMESTAMP
,TIMESTAMP_TZ
,VARCHAR
.DECIMAL
parameters are currently not supported, they can only be specified as strings on API level, so casts to/fromVARCHAR
can be used instead.Only positional parameters are supported -
STRUCT
field names are ignored.Testing: new tests added for
mysql_query
andmysql_execute
fuctions.