Skip to content

typing: fix 1.4.1 stubs #131

@dangotbanned

Description

@dangotbanned

Originally posted by @dangotbanned in #124

Downstream in narwhals, I've got a PR open which is trying to adjust to the new stubs:

From #96 the issues we have seem to stem from (236713a) and (f5d4e42) after which we get a lot of false negatives on:

  • ConstantExpression
  • LambdaExpression
  • DuckDBPyType

I think the fixes I have for ConstantExpression + LambdaExpression would be pretty minor.

There's 1 or 2 examples for ConstantExpression in the test suite already 😉

Show ConstantExpression

image

DuckDBPyType might be a little more involved, since it's an issue with children.
Also the way I've worked around it in narwhals probably wouldn't be the same thing I'd write in the stubs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions