Fix Polars expr pushdown #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #98
We have our own Polars IO plugin to create lazy polars dataframes. We try to push as many predicates down into DuckDB as we can, for which we try to map Polars expressions (including datatypes) to SQL expressions. To do this we depend on Polar's
Expr.meta.serialize
.None of this is very stable. Polars IO source plugins are marked
@unstable
andExpr.meta.serialize
says "Serialization is not stable across Polars versions".In this case the problems seems to come from Polars requiring an explicit scale to be set for decimals (this pr). The serialized format seems to have changed into:
Interestingly, even if we explicitly set precision to e.g. 20, the relevant part of the serialized expression looks as follows:
This PR allows for both a 2 and 3 item list for decimals.