[minor][spark] Minor bugfixes #180
Merged
+324
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 small bugs:
When you call asin(2.0) or acos(5.0) (values outside the valid range), PySpark is supposed to return NaN. DuckDB
was returning NULL instead, which breaks code that expects PySpark behavior. Fixed by using a SQL workaround since
the internal C++ layer converts NaN to NULL by design.
The spark.read.json() method had all the code written, but a raise NotImplementedError at the end blocked it
from ever returning. One line removal fixed it.
Instead of hitting a generic NotImplementedError when encountering DuckDB union types (which PySpark doesn't
support), it now throws a clear ContributionsAcceptedError explaining the limitation.