Bump retrofit and remove retrofitCoroutinesAdapter dependency #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove retrofit-coroutine adapter library (deprecated: https://github.com/JakeWharton/retrofit2-kotlin-coroutines-adapter#kotlin-coroutine-adapter-deprecated) Adapt code to introduce suspend operator
…pter_retrofit # Conflicts: # build.gradle
…pter_retrofit # Conflicts: # app/build.gradle
Contributor
Author
|
@marcosholgado this is ready for a review. Conflicts solved and tests are passing now. |
marcosholgado
approved these changes
Feb 5, 2021
Contributor
marcosholgado
left a comment
marcosholgado
left a comment
There was a problem hiding this comment.
Good job @cmonfortep, I left a minor comment but feel free to merge.
app/src/androidTest/java/com/duckduckgo/app/statistics/AtbInitializerTest.kt
Show resolved
Hide resolved
cmonfortep
deleted the
feature/cristian/lhf/remove_coroutine_adapter_retrofit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1199111180919669/f
Tech Design URL:
CC:
Description:
This PR updates retrofit version and remove the deprecated dependency with
retrofitCoroutinesAdapter.Steps to test this PR:
Successfully submitted feedbackDisclaimer: we noticed that this API is pretty slow (up to 5 seconds), when testing be aware of this when waiting for the log to appear.
Internal references:
Software Engineering Expectations
Technical Design Template