Decouple the DaggerWorkerFactory using plugins #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
force-pushed
the
poc/aitor/plugins
branch
from
b33533d to
8ade7ef
Compare
aitorvs
force-pushed
the
poc/aitor/plugins
branch
from
8ade7ef to
f9ec26c
Compare
aitorvs
force-pushed
the
poc/aitor/plugins
branch
from
f9ec26c to
6177d9a
Compare
marcosholgado
requested changes
Feb 9, 2021
Contributor
marcosholgado
left a comment
marcosholgado
left a comment
There was a problem hiding this comment.
Nice job @aitorvs! I noticed the clear data notification does not show up anymore, left a couple of comments about that.
| notificationDao: NotificationDao, | ||
| notificationFactory: NotificationFactory, | ||
| pixel: Pixel, | ||
| privacyProtectionNotification: PrivacyProtectionNotification |
Contributor
There was a problem hiding this comment.
Should this be ClearDataNotification?
| private val notificationDao: NotificationDao, | ||
| private val notificationFactory: NotificationFactory, | ||
| private val pixel: Pixel, | ||
| private val privacyProtectionNotification: PrivacyProtectionNotification |
Contributor
There was a problem hiding this comment.
Should this be ClearDataNotification?
Collaborator
Author
Thanks @marcosholgado, good catch! it should be fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1199916263225059/f
Tech Design URL:
CC:
Description:
Use dagger multibindings to decouple the
DaggerWorkerFactory.The
DaggerWorkerFactoryis a big object that creates the workers AND inject its dependencies. For that reason it needs to know and depend on ALL dependencies all the app workers require. Which makes it a god object.In this PR I use dagger multibindings to setup a kind of plugin system where the
DaggerWorkerFactorycan delegate the injection of dependencies to the worker plugins.Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template