Fixed the back navigation after web search #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initpwn
approved these changes
Feb 1, 2021
Contributor
|
Thanks @subin-chella. I will review and test this PR today 💯 |
cmonfortep
approved these changes
Feb 6, 2021
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
Thanks, changes look good, and I've tested this on a few devices, and works great.
I will merge it on Monday. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: #1070
Tech Design URL:
CC: https://app.asana.com/0/414730916066338/1199905075709368/f
Fixed the issue by passing the current tab id to onOpenInNewTabRequested function while performing web search
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template