Skip to content

Make privacy grade clickable when grade is loading #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

Make privacy grade clickable when grade is loading #1088

merged 1 commit into from
Feb 10, 2021

Conversation

@marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented Feb 5, 2021

Task/Issue URL: https://app.asana.com/0/1125189844152671/1191242003013179
Tech Design URL:
CC:

Description:
This PR makes the privacy grade clickable while the grade is loading.

Steps to test this PR:

  1. Go to a site that takes a few seconds to load, a good example is the first time that cnn.com loads.
  2. While loading (privacy grade is completely black) click on the privacy grade.
  3. You should be taken to the privacy dashboard.
Internal references:

Software Engineering Expectations
Technical Design Template

@marcosholgado marcosholgado merged commit 8f49a78 into develop Feb 10, 2021
@marcosholgado marcosholgado deleted the feature/marcos/enable_grade_when_loading branch February 10, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CDRussell CDRussell CDRussell approved these changes

Assignees

@CDRussell CDRussell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcosholgado @CDRussell