-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Onboarding optimizations #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcosholgado
merged 10 commits into
develop
from
feature/marcos/make_dax_dialog_non_dismissable
Feb 12, 2021
Merged
Onboarding optimizations #1089
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6525e42
Do not dismiss dax dialogs when clicking outside.
marcosholgado 4afff97
Second tap dismisses the dialog
marcosholgado 341304b
If animation has finished, tapping outside dismisses the dialog.
marcosholgado 96a9477
Finish animation for Dax CTAs
marcosholgado 44ed20d
Undo unnecessary change
marcosholgado 08b15ab
Welcome page new behaviour and new icon
marcosholgado 3977706
Change variable name
marcosholgado 98069b2
spotless
marcosholgado 2adf646
Amend code as per PR comments
marcosholgado 7ddf81a
Change default value for dismissible
marcosholgado File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,7 +51,7 @@ class TypewriterDaxDialog : DialogFragment(), DaxDialog { | |
| private var primaryButtonText: String = "" | ||
| private var secondaryButtonText: String = "" | ||
| private var toolbarDimmed: Boolean = true | ||
| private var dismissible: Boolean = true | ||
| private var dismissible: Boolean = false | ||
| private var typingDelayInMs: Long = DEFAULT_TYPING_DELAY | ||
| private var showHideButton: Boolean = true | ||
|
|
||
|
|
@@ -161,10 +161,14 @@ class TypewriterDaxDialog : DialogFragment(), DaxDialog { | |
| dismiss() | ||
| } | ||
|
|
||
| if (dismissible) { | ||
| dialogContainer.setOnClickListener { | ||
| dialogContainer.setOnClickListener { | ||
| if (dismissible) { | ||
marcosholgado marked this conversation as resolved.
Show resolved
Hide resolved
cmonfortep marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| dialogText.cancelAnimation() | ||
| dismiss() | ||
| } else { | ||
| if (!dialogText.hasAnimationFinished()) { | ||
| dialogText.finishAnimation() | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -194,7 +198,7 @@ class TypewriterDaxDialog : DialogFragment(), DaxDialog { | |
| primaryButtonText: String, | ||
| secondaryButtonText: String? = "", | ||
| toolbarDimmed: Boolean = true, | ||
| dismissible: Boolean = true, | ||
| dismissible: Boolean = false, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, this is perfect, but I would also change line
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 changed! |
||
| typingDelayInMs: Long = DEFAULT_TYPING_DELAY, | ||
| showHideButton: Boolean = true | ||
| ): TypewriterDaxDialog { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.