Skip to content

Conversation

@jonathanKingston
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/11472677167855/1185888722207947
Tech Design URL:
CC:

Description:

Depends on SERP repo being merged: https://dub.duckduckgo.com/duckduckgo/ddg/pull/21513


Internal references:

Software Engineering Expectations
Technical Design Template

@malmstein
Copy link
Contributor

SERP PR is merged, @jonathanKingston is there anything we need to do in order to test this?

@jonathanKingston
Copy link
Collaborator Author

@malmstein I was looking through the Android code and my understanding is TrackerDataLoader is surfaced to TrackerDetectorImpl which sole responsibility is to block tracker URLs in content pages.

The lists are now different: https://duckduckgo.com/contentblocking/trackers-whitelist-temporary.txt and https://duckduckgo.com/contentblocking/trackers-unprotected-temporary.txt so loading scripts from those two different domains into a page shouldn't be blocked with the change.

Perhaps @subsymbolic would be able to say if there's a better way to test this? Perhaps checking the browser is downloading the right list with network tools?

Also I'd like to note this is just to fix the URL, there are still other places where the terminology should change etc.

@subsymbolic
Copy link
Contributor

@malmstein in case it helps, I would test this as follows:

  • Install the app fresh to make sure none of the data already exists in our db from the previous end-point
  • Launch the app and wait for all backend syncing to happen
  • Visit a couple of urls in https://duckduckgo.com/contentblocking/trackers-unprotected-temporary.txt and make sure that NO trackers are identified
  • You should also see a comment in the console that the site is whitelisted (as mentioned we still have some of that old terminology in the app)

@malmstein
Copy link
Contributor

Thanks @subsymbolic, I'll take care of it @jonathanKingston !

@malmstein malmstein self-assigned this Feb 23, 2021
@malmstein
Copy link
Contributor

Thanks @jonathanKingston @subsymbolic, works as expected!

Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@malmstein malmstein merged commit ae1a549 into duckduckgo:develop Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants