Do not send rq.1 when the user is NOT in the SERP #1096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1199905759163742/f
Tech Design URL:
CC:
Description:
We should not send rq.1 pixels when the user is in NOT in the SERP, ie. the search bar contains a valid URL
Repro steps of the bug
Steps to test this PR:
(to see when rq pixels are sent, filter logcat with
rq_)Verify the following test flow
rq.xpixels are NOT sentrq.0pixel is sentrq.0is sentrq.0is sentrq.1pixel is sentrq.xpixels are NOT sentrq.xpixels are NOT sentrq.1pixel is sentrq.xpixels are not sentalso verify the test scenario in https://app.asana.com/0/0/1199922227966104/f
Internal references:
Software Engineering Expectations
Technical Design Template