Skip to content

Conversation

@aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Feb 10, 2021

Task/Issue URL: https://app.asana.com/0/414730916066338/1199905759163742/f
Tech Design URL:
CC:

Description:
We should not send rq.1 pixels when the user is in NOT in the SERP, ie. the search bar contains a valid URL

Repro steps of the bug

  • open browser
  • load website, eg. http://example.com
  • tap on search bar
  • search for "reddit"
  • select "🔎 reddit"
  • verify rq.1 pixel is wrongly fired ❌

Steps to test this PR:
(to see when rq pixels are sent, filter logcat with rq_)

Verify the following test flow

  • open app and search reddit
  • Verify rq.x pixels are NOT sent
  • pull to refresh
  • verify rq.0 pixel is sent
  • overflow menu -> refresh
  • verify rq.0 is sent
  • tap on search bar
  • select "🔎 reddit" from autocomplete
  • verify rq.0 is sent
  • tap on search bar and select "🔎 reddit politics" (or any other reddit xxx autocomplete result)
  • Verify rq.1 pixel is sent
  • click on a link in SERP, open it in a new tab and wait for it to load
  • verify rq.x pixels are NOT sent
  • tap on the search bar and search for "reddit"
  • select "🔎 reddit"
  • verify rq.x pixels are NOT sent
  • tap on search bar and select "🔎 reddit politics" (or any other reddit xxx autocomplete result)
  • Verify rq.1 pixel is sent
  • close the app and re-open
  • Verify rq.x pixels are not sent

also verify the test scenario in https://app.asana.com/0/0/1199922227966104/f


Internal references:

Software Engineering Expectations
Technical Design Template

@malmstein malmstein self-assigned this Feb 10, 2021
@aitorvs
Copy link
Collaborator Author

aitorvs commented Feb 11, 2021

@malmstein this is ready to reviews. Also perform the test as per https://app.asana.com/0/0/1199922227966104/f

Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the different scenarios and worked as expected, gj @aitorvs!

@aitorvs aitorvs merged commit 69693a1 into develop Feb 12, 2021
@aitorvs aitorvs deleted the fix/aitor/rq branch February 12, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants