Swipe to refresh is too sensitive #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
approved these changes
Feb 22, 2021
Contributor
malmstein
left a comment
malmstein
left a comment
There was a problem hiding this comment.
just a comment regarding naming, this is really nice @marcosholgado !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1125189844152671/1199888021167463
Tech Design URL:
CC:
Description:
This PR changes how we enable swipe to refresh so it only happens once a website is clamped at the top AND a new gesture begins. This should fix #1081
Steps to test this PR:
https://m.xkcd.com/2425/Internal references:
Software Engineering Expectations
Technical Design Template