Skip to content

Conversation

@marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented Feb 23, 2021

Task/Issue URL: https://app.asana.com/0/72649045549333/1199969297683315
Tech Design URL:
CC:

Description:
When you are watching a video or any content in fullscreen, after you come back from fullscreen if there is an edit/search field in the website the keyboard won't show anymore until you click on the omnibar to get the focus back. This PR requests the focus back when coming back from fullscreen.

Steps to test this PR:

  1. Go to youtube.com
  2. Start watching any video
  3. Change the video so you watch it in fullscreen (click on the square on the bottom right side)
  4. Go back to normal mode (click on the square on the bottom right side or the back button)
  5. Click on the search icon
  6. Keyboard should show up

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcosholgado marcosholgado merged commit cd2108e into develop Feb 24, 2021
@marcosholgado marcosholgado deleted the feature/marcos/keyboard_fullscreen_bug branch February 24, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants