Refactor the ViewModelFactory to use multibindings #1123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1199916263225062/f
Tech Design URL:
CC:
Description:
The
ViewModelFactoryis in charge of creating all the view models for the whole app. Before it had to:By using the plugin pattern in this class we:
Factoryclass from the actual factories that create the view modelsFactorycan now live in different modules if needed without creating circular dependenciesSteps to test this PR:
This PR affects pretty much the whole app as it touches all the view models we've got. To test the PR test the common app screens to see if something is amiss.
Internal references:
Software Engineering Expectations
Technical Design Template