Skip to content

Android: streamline home screen load #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Mar 11, 2021
Merged

Android: streamline home screen load #1124

merged 46 commits into from
Mar 11, 2021

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Mar 9, 2021 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1200024092221607/f
Tech Design URL:
CC:

Description:
This PR includes changes to make our clear data restart process smoother and faster:

  • Removed fade-in transitions
  • DDG logo fixed position
  • Removed Data clear message when the user clears data manually (automatic data clear still shows the confirmation message)
  • layout optimizations
  • dagger graph initialized only for the app process (fire process will not initialize dagger injector)
  • Browser activity has a dummy omnibar to avoid showing a white full screen

Steps to test this PR:
Test 1:

  1. Perform fresh install
  2. Clear data in the 3 different possible scenarios (during onboarding, onboarding completed - widget cta, onboarding completed - no Ctas)

Test 2:

  1. Ensure automatic data clear works as usual (includes optimization changes but data clear message shows up if app cleared in foreground)

See videos posted in product review to validate expected behavior

Internal references:

Software Engineering Expectations
Technical Design Template

@cmonfortep
add checkpoints to report startup times
9f2994a
@cmonfortep
code to trace app start
188979d
@cmonfortep
mockup version of our omnibar to load it in browserActivity and speed…
0a993a3 
… up first rendered screen
@cmonfortep
unnecessary element in layout
23cdcdb
@cmonfortep
replace contraintlayout for framelayout, optimization
7ff8451
@cmonfortep
replace contraintlayout for framelayout
c607ee9
@cmonfortep
replace contraintlayout for framelayout
fd3c8b6
@cmonfortep
show mockup toolbar in browseractivity
bb3e86c
@cmonfortep
make errorSnackbar lazy
5623ee4
@cmonfortep
delay popupbrowsermenu creation until requested
48b15f4
@cmonfortep
replace contraintlayout from popup menu by linearlayout
b0b6170
@cmonfortep
disable including url mockup in browseractivity
8905128
@cmonfortep
remove top_cta from layout. It will never appear based on our current…
d00ef75 
… logic.
@cmonfortep
set all views gone to avoid rendering them when view inflated
614785e
@cmonfortep
remove constraint layout from find_in_page layout
16e0abc
@cmonfortep
Simplify toolbar_mockup layout
b629123
@cmonfortep
Remove unnecessary contraintlayouts
e7642f7
@cmonfortep
animate fragment from bottom after clearing data
1c7ab66
@cmonfortep
Refactor DDGLogoListener to just hide-show background image
50abe49
@cmonfortep
leave a comment to document why animation is in place
20f69a3
@cmonfortep
remove debuggable flag (used to measure performance, not needed anymore)
52d0676
@cmonfortep
Remove logic used to measure performance
4e3db91
@cmonfortep
show data cleared message in Dark screen on process restart
575c8b4
@cmonfortep
show hint in mockup urlbar
270eff6
@cmonfortep
show mockup url bar on browserActivity
20384ba
@cmonfortep
no transitions to smooth process restart
6c41d4d
@cmonfortep
Remove Toast from BrowserActivity
65353bf
@cmonfortep
Don't show data cleared test in black restart screen
e1beaa8
@cmonfortep
Avoid to initialise dependency injection when process restarting due …
d1253e8 
…to clear data
@cmonfortep
temp commit (WIP views that will inflate later should not be accessib…
4224413 
…le without checkin nullability)
@cmonfortep cmonfortep changed the title Feature/cristian/streamline home start Android: streamline home screen load Mar 9, 2021
@cmonfortep cmonfortep marked this pull request as ready for review March 9, 2021 14:54
marcosholgado
marcosholgado requested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @cmonfortep! Looks amazing and much faster than before, specially on 21! I left a few comments but nothing major.

  • Tested in API 21 and 30
  • Light/dark mode
  • Clear data feature

@cmonfortep
Copy link
Contributor Author

cmonfortep commented Mar 11, 2021

@marcosholgado could you re-review this again? Thanks!

marcosholgado
marcosholgado approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @cmonfortep! Ship it! 👍

@cmonfortep cmonfortep merged commit e657354 into develop Mar 11, 2021
@cmonfortep cmonfortep deleted the feature/cristian/streamline_home_start branch March 11, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcosholgado marcosholgado marcosholgado approved these changes

Assignees

@marcosholgado marcosholgado

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmonfortep @marcosholgado