Skip to content

Leak after responding to Rate dialog #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Leak after responding to Rate dialog #1126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ class BrowserActivity : DuckDuckGoActivity(), CoroutineScope by MainScope() {

private var lastIntent: Intent? = null

private var currentAppEnjoymentFragment: DialogFragment? = null

private lateinit var renderer: BrowserStateRenderer

private var openMessageInNewTabJob: Job? = null
Expand Down Expand Up @@ -433,9 +431,8 @@ class BrowserActivity : DuckDuckGoActivity(), CoroutineScope by MainScope() {
get() = (flags and Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY) == Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY

private fun showAppEnjoymentPrompt(prompt: DialogFragment) {
currentAppEnjoymentFragment?.dismiss()
(supportFragmentManager.findFragmentByTag(APP_ENJOYMENT_DIALOG_TAG) as? DialogFragment)?.dismiss()
prompt.show(supportFragmentManager, APP_ENJOYMENT_DIALOG_TAG)
currentAppEnjoymentFragment = prompt
}

private fun hideWebContent() {
Expand Down