Extensible PixelName API #1129
Merged
Extensible PixelName API #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
force-pushed
the
feature/aitor/pixels
branch
from
ca42480 to
4d34aa7
Compare
aitorvs
force-pushed
the
feature/aitor/pixels
branch
from
4d34aa7 to
f913790
Compare
aitorvs
commented
Mar 12, 2021
Comment on lines
+32
to
+39
| WEB_RENDERER_GONE_CRASH("m_d_wrg_c"), | ||
| WEB_RENDERER_GONE_KILLED("m_d_wrg_k"), | ||
|
|
||
| APP_LAUNCH("ml"), | ||
|
|
||
| FORGET_ALL_PRESSED_BROWSING("mf_bp"), | ||
| FORGET_ALL_PRESSED_TABSWITCHING("mf_tp"), | ||
| FORGET_ALL_EXECUTED("mf"), | ||
| FORGET_ALL_AUTO_RESTART("m_f_r"), | ||
| FORGET_ALL_AUTO_RESTART_WITH_INTENT("m_f_ri"), | ||
| COOKIE_DATABASE_NOT_FOUND("m_cdb_nf"), | ||
| COOKIE_DATABASE_OPEN_ERROR("m_cdb_oe"), | ||
| COOKIE_DATABASE_DELETE_ERROR("m_cdb_de"), | ||
| COOKIE_DATABASE_CORRUPTED_ERROR("m_cdb_ce"), |
Collaborator
Author
There was a problem hiding this comment.
These pixels are use in the OfflinePixelSender that lives in the statistics gradle module.
I think at some point we should also look into not having these pixels in the statistics gradle module. Ideally it should only contain the public API for the pixels, but none of the pixel names to be sent.
for now I just left these here
malmstein
approved these changes
Mar 15, 2021
| fun verifyNoDuplicatePixelNames() { | ||
| val existingNames = mutableSetOf<String>() | ||
| Pixel.PixelName.values().forEach { | ||
| AppPixelName.values().forEach { |
| Pixel.PixelName.values().forEach { | ||
| AppPixelName.values().forEach { | ||
| if (!existingNames.add(it.pixelName)) { | ||
| fail("Duplicate pixel name found: ${it.pixelName}") |
Contributor
There was a problem hiding this comment.
Maybe be more specific towards what type of pixel is missing? Something like "Duplicate app / statistics pixel name found"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1200049149472987/f
Tech Design URL: https://app.asana.com/0/715106103902962/1200043236683507/f
CC:
Description:
This PR
PixelNameas an interface so that it can be extendedSteps to test this PR:
(it is not extrictly necessary to perform any test as all issues should be detected at compile time)
Internal references:
Software Engineering Expectations
Technical Design Template