-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix Google auth flow to allow users to sign in #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonfortep
approved these changes
Mar 26, 2021
Contributor
cmonfortep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ, all minor comments or related to naming.
I've tested all scenarios and worked as described. The only scenario I was not able to test is Implicit flow same tab on Nest because I don't have an account there.
app/src/main/java/com/duckduckgo/app/browser/cookies/db/AllowedDomainsDao.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/browser/cookies/db/AllowedDomainsRepositoryTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/cookies/db/AllowedDomainsRepository.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/browser/cookies/db/AllowedDomainsRepositoryTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/cookies/ThirdPartyCookieManager.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/browser/cookies/AppThirdPartyCookieManagerTest.kt
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserWebViewClient.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1125189844152671/1200105784338364
Tech Design URL: One, Two, Three
CC:
Description:
This PR identifies when a Google auth flow will require third party cookies to be enabled and do so once after the sign in flow finishes to allow users to successfully sign in.
Steps to test this PR:
Implicit flow in new tab
pinterest.com. You can also test ingumtree.com,yelp.comorindeed.comCookies disabled for pinterestContinue with Google, a new tab should openCookies enabled for pinterestand you should be signed in.Cookies disabled for xxxin the logcat.Implicit flow same tab on Nest
home.nest.comCookies disabled for pinterestSign in with GoogleCookies enabled for home.nest.com.Cookies enable for home.nest.comBasic auth flow
etsy.com. You can try other sites likeimdb.com,dropbox.com,yell.com,lego.com, etc.Cookies enabled for xxxxetsy.comsuccessfully signed in.Incomplete sign in flow
pinterest.com. You can also test ingumtree.com,yelp.comorindeed.comCookies disabled for pinterestContinue with Google, a new tab should openpinterestshould have been added toallowed_domainsCookies enabled for pinterest.pinterestdomain should have been deleted from theallowed_domainstableFire button
pinterest.com. You can also test ingumtree.com,yelp.comorindeed.comCookies disabled for pinterestContinue with Google, a new tab should openpinterestshould have been added toallowed_domainspinterestdomain should have been deleted fromallowed_domainspinterest.comyou should not seeCookies enabled for pinterestin the logcat.home.nest.comsince it always requires 3p cookies enabled.Internal references:
Software Engineering Expectations
Technical Design Template