Update Anvil and contribute multibindings for workers #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
commented
Mar 31, 2021
Comment on lines
-44
to
-47
| implementation AndroidX.room.rxJava2 | ||
| kapt AndroidX.room.compiler | ||
| testImplementation AndroidX.room.testing | ||
| androidTestImplementation AndroidX.room.testing |
Collaborator
Author
There was a problem hiding this comment.
We have room entities here but we don't need to have the room annotation processor here. We just need access to the annotations. The app module will take care of the code generation.
This should also improve build times a bit
aitorvs
commented
Mar 31, 2021
| version.com.nhaarman.mockitokotlin2..mockito-kotlin=2.1.0 | ||
| version.google.android.material=1.2.1 | ||
| version.google.dagger=2.27 | ||
| version.google.dagger=2.32 |
Collaborator
Author
There was a problem hiding this comment.
Updated dagger to have the same version than anvil 2.2.0.
aitorvs
commented
Mar 31, 2021
| id 'com.android.library' | ||
| id 'kotlin-android' | ||
| id 'kotlin-kapt' | ||
| id 'com.squareup.anvil' |
Collaborator
Author
There was a problem hiding this comment.
kapt is not needed here. it should improve a bit build times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1200105747936521/f
Tech Design URL:
CC:
Description:
This PR updates anvil to version 2.2.0. Anvil now provides a new handy annotation
ContributesMultibindingthat allow us to contribute dependencies into sets, like we do for eg. workers or view model factories.Using that annotation allow us to remove a bunch of boilerplate code.
In this PR we:
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template