Feature/david/journal mode #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
approved these changes
Apr 1, 2021
Collaborator
aitorvs
left a comment
aitorvs
left a comment
There was a problem hiding this comment.
lgtm. Left couple comments of things I think we need to remove:
- the version 5.80.0
- the debuggable flag
other than that, I tested and works as expected. Awesome job @malmstein
app/build.gradle
Outdated
| } | ||
| release { | ||
| minifyEnabled false | ||
| debuggable true |
Collaborator
There was a problem hiding this comment.
I guess we want to remove this (?)
|
|
||
| val CHANGE_JOURNAL_ON_OPEN = object : RoomDatabase.Callback() { | ||
| override fun onOpen(db: SupportSQLiteDatabase) { | ||
| db.query("PRAGMA journal_mode=DELETE;").use { cursor -> cursor.moveToFirst() } |
app/version/version.properties
Outdated
| @@ -1 +1 @@ | |||
| VERSION=5.79.0 No newline at end of file | |||
| VERSION=5.80.0 No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
We probably want to remove this too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1157893581871903/1200123654543284
Description:
Background
Change the journal type from write ahead logging to delete.
This means we won't have to close the database hence avoiding all the threading issues.
Estimate: Couple of days
This approach is much faster and solves the main issue at hand, thus the preferred approach
Steps to test this PR:
Download apk from Jenkins https://jenkins.duckduckgo.com/job/android%20-%20duckduckgo%20app%20release/255/
Internal references:
Software Engineering Expectations
Technical Design Template