Skip to content

Conversation

@CDRussell
Copy link
Member

Task/Issue URL: https://app.asana.com/0/414730916066338/1184175637619353/f
Tech Design URL:
CC:

Description:
Adds call to sanitise Intent in the BrowserActivity.onCreate() function

Steps to test this PR:

  1. Same steps to test as in Android: Protect app from crashing due to unsafe input from 3rd parties #953, use the snippet provided here and verify no crash happens

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 it

Thanks for taking this one 👍

@CDRussell CDRussell merged commit 8afea7e into develop Apr 9, 2021
@CDRussell CDRussell deleted the feature/craig/santize_browser_activity_onCreate branch April 9, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants