Skip to content

Conversation

@marcosholgado
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1125189844152671/1200168757349077
Tech Design URL:
CC:

Description:
This PR removes all the https pixels

Steps to test this PR:

Install from develop

  1. Go to serp.
  2. You should see the pixel m_https_nl.
  3. Go to a long and random url like http://asdasdqweasdasedqweasd.com
  4. You should see the pixel m_https_nu.

Install from the branch

  1. Go to serp.
  2. You should not see the pixel m_https_nl.
  3. Go to a long and random url like http://asdasdqweasdasedqweasd.com
  4. You should not see the pixel m_https_nu.

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@marcosholgado marcosholgado merged commit 6206eea into develop Apr 8, 2021
@marcosholgado marcosholgado deleted the feature/marcos/remove_https_pixels branch April 8, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants