updated system search activity to match the current designs #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonfortep
approved these changes
Apr 12, 2021
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
LGTM. Very nice and good job @malmstein
Friendly reminder: I haven't tested this on low api. Just on my device and an emulator (api 29).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/715106103902962/1199987030166438
Description:
Our interstitial search screen looks inconsistent with other UI in our app.
Updating this UI will make using the interstitial search feel more similar to what users are already used to in our app.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template