Pull to refresh sensitivity fix #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDRussell
approved these changes
Apr 16, 2021
Member
CDRussell
left a comment
CDRussell
left a comment
There was a problem hiding this comment.
Still notice an issue on https://makecode.microbit.org/projects/guitar/displaybuttons where it's possible fill the WebView view with content that's hard to scroll away from, but there is an improvement on the other sites.
Approving since it seems like an obvious improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/inbox/1125189844075764/1200092328111314/1200200821708976
Tech Design URL:
CC:
Description:
This PR fixes some bug reports where pull to refresh is triggered incorrectly while scrolling on a map or some other interactive content. This also can happen if the site has its own toolbar. This PR fixes #1132
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template