Fix fire animation #1199
Merged
Fix fire animation #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
reviewed
Apr 22, 2021
| private fun animationEnabled() = settingsDataStore.fireAnimationEnabled && animatorDurationEnabled() | ||
|
|
||
| private fun animatorDurationEnabled(): Boolean { | ||
| val animatorScale = Settings.Global.getFloat(context.contentResolver, ANIMATOR_DURATION_SCALE, 1.0f) |
Collaborator
There was a problem hiding this comment.
I think default value should not be 1f but rather 0.0f To fall on the safe side when the value is not defined.
Contributor
Author
There was a problem hiding this comment.
Good spot @aitorvs, I've made the appropriate change.
Collaborator
|
Good job @jamie23 . I left one minor comment to error on the safe side. I have tested this for:
All working properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: #1159
Tech Design URL:
CC:
Description:
When we check that the animation is enabled we can also check that the animator duration scale is set, if it is set to 0 then we skip the animation.
Steps to test this PR:
Animator duration scaletoAnimation offClear all tabs and data.Internal references:
Software Engineering Expectations
Technical Design Template