Skip to content

Conversation

@brindy
Copy link
Contributor

@brindy brindy commented Jan 18, 2018

Asana Issue URL: https://app.asana.com/0/488551667048375/471444661339649

Description

Migrates legacy favourites to bookmarks.

Legacy code has been used and I tried to change as little as possible (but have deleted a fair chunk).

Haven't tested migrating from older databases but I would like to assume that code has been well tested already and it's the same code used here.

Steps to Test this PR:

  1. Build and run Search and Stories (sorry! Remember to update to get the required submodule and you may need to install a bunch of older android build tools versions)
  2. Favourite a couple of stories
  3. Perform a search and favourite it
  4. Browse to a page and favourite it
  5. Install new app
  6. Go to bookmarks and confirmed migrated favourites and searches are present and all bookmarks open correctly.

Copy link
Contributor

@subsymbolic subsymbolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@@ -0,0 +1,104 @@
/*
* Copyright (c) 2018 DuckDuckGo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I've had to look at Java :)

@brindy brindy merged commit cb81977 into develop Jan 18, 2018
@brindy brindy deleted the feature/migration branch January 18, 2018 20:49
aitorvs pushed a commit that referenced this pull request Nov 18, 2021
Co-authored-by: David González <malmstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants