Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/inbox/1125189844075764/1200216229834032/1200216231039639
Tech Design URL: https://app.asana.com/0/1198207348643509/1200195761608655
CC:
Description:
This PR changes the way we find surrogates for requests, rather than matching the full URL of the intercepted request we now rely on Tracker Radar data for this.
Steps to test this PR:
Migrate from develop
developFound new surrogate rule: google-analytics.com/ga.js - application/javascriptautotrader.co.uk, insert a postcode likeLS9 8BAand press search.Surrogate found for https://www.googletagservices.com/tag/js/gpt.jsFound new surrogate rule: ga.js - google-analytics.com/ga.js - application/javascriptNotice how we are now extracting the script id as well.autotrader.co.uk, insert a postcode likeLS9 8BAand press search.Surrogate found for https://www.googletagservices.com/tag/js/gpt.jsNormal test
Found new surrogate rule: ga.js - google-analytics.com/ga.js - application/javascriptNotice how we are now extracting the script id as well.autotrader.co.uk, insert a postcode likeLS9 8BAand press search.Surrogate found for https://www.googletagservices.com/tag/js/gpt.jsInternal references:
Software Engineering Expectations
Technical Design Template