Skip to content

Conversation

@marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented Apr 23, 2021

Task/Issue URL: https://app.asana.com/0/inbox/1125189844075764/1200216229834032/1200216231039639
Tech Design URL: https://app.asana.com/0/1198207348643509/1200195761608655
CC:

Description:
This PR changes the way we find surrogates for requests, rather than matching the full URL of the intercepted request we now rely on Tracker Radar data for this.

Steps to test this PR:

Migrate from develop

  1. Install and launch the app from develop
  2. In the logcat you should see a few statements like Found new surrogate rule: google-analytics.com/ga.js - application/javascript
  3. Go to autotrader.co.uk, insert a postcode like LS9 8BA and press search.
  4. The search results should not show and the progress indicator should be stuck.
  5. In the logcat you should not see Surrogate found for https://www.googletagservices.com/tag/js/gpt.js
  6. Install now from this branch.
  7. In the logcat you should see a few statements like Found new surrogate rule: ga.js - google-analytics.com/ga.js - application/javascript Notice how we are now extracting the script id as well.
  8. Go to autotrader.co.uk, insert a postcode like LS9 8BA and press search.
  9. The search results correctly show up
  10. In the logcat you should now see Surrogate found for https://www.googletagservices.com/tag/js/gpt.js

Normal test

  1. Install now from this branch.
  2. In the logcat you should see a few statements like Found new surrogate rule: ga.js - google-analytics.com/ga.js - application/javascript Notice how we are now extracting the script id as well.
  3. Go to autotrader.co.uk, insert a postcode like LS9 8BA and press search.
  4. The search results correctly show up
  5. In the logcat you should now see Surrogate found for https://www.googletagservices.com/tag/js/gpt.js

Internal references:

Software Engineering Expectations
Technical Design Template

@marcosholgado marcosholgado merged commit ae3bc5a into develop Apr 26, 2021
@marcosholgado marcosholgado deleted the feature/marcos/fix_surrogates_algorithm branch April 26, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants