UOA experiment 2nd iteration #1205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/inbox/1125189844075764/1200252649107473/1200229532781040
Tech Design URL:
CC:
Description:
This PR disabled the previous experiment and creates two new variants. The experimental variant now enables all the inactive notification as long as the don't clash with the UOA notification. If that's the case we delay the inactive notification by one day.
Before testing
In the
AndroidNotificationSchedulerchange lines85and89so they passTimeUnit.SECONDSinstead of days.In the
AndroidNotificationSchedulerchange line 102 toreturn duration * 10to give the notification more than 1 second to be sent.Steps to test this PR:
ZY experimental variant
Change the variant to always use
zyDay 0
AppInstallStoreto return 0notificationyou should seeInactive notification days installed is 0 day is 1Scheduling notification for 10-> scheduled for 1 day laternotificationyou should seeInactive notification days installed is 0 day is 3Scheduling notification for 40-> scheduled for 4 days laterDay 2
AppInstallStoreto return 2notificationyou should seeInactive notification days installed is 2 day is 1Scheduling notification for 20-> scheduled for 2 days laternotificationyou should seeInactive notification days installed is 2 day is 3Scheduling notification for 30-> scheduled for 3 days laterTesting any other days (step 1) should always return 10 for the privacy notification and 30 for the clear data notification since those notification cannot clash with the UOA notification out of day 0 and 2.
ZX experimental variant
Change the variant to always use
zxDay 0
AppInstallStoreto return 0notificationyou should seeInactive notification days installed is 0 day is 1Scheduling notification for 10-> scheduled for 1 day laternotificationyou should seeInactive notification days installed is 0 day is 3Scheduling notification for 30-> scheduled for 3 days laterDay 2
AppInstallStoreto return 2notificationyou should seeInactive notification days installed is 2 day is 1Scheduling notification for 10-> scheduled for 1 day laternotificationyou should seeInactive notification days installed is 2 day is 3Scheduling notification for 30-> scheduled for 3 days laterTesting any other days (step 1) should always return 10 for the privacy notification and 30 for the clear data notification since those notification cannot clash with the UOA notification out of day 0 and 2.
Internal references:
Software Engineering Expectations
Technical Design Template